[CIR][Lowering] Deprecate attributes for LLVM zero-initialization #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. [ghstack-poisoned]
This was referenced Aug 7, 2023
sitio-couto
added a commit
that referenced
this pull request
Aug 7, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: bc3e2f9 Pull Request resolved: #221
…ization" This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. [ghstack-poisoned]
sitio-couto
added a commit
that referenced
this pull request
Aug 7, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: ad80cb2 Pull Request resolved: #221
sitio-couto
added a commit
to sitio-couto/clangir
that referenced
this pull request
Aug 8, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: bc3e2f9 Pull Request resolved: llvm#221
bcardosolopes
requested changes
Aug 9, 2023
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
This depends on another requested changes PR.
bcardosolopes
approved these changes
Aug 21, 2023
…ization" This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. [ghstack-poisoned]
sitio-couto
added a commit
that referenced
this pull request
Aug 21, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
sitio-couto
added a commit
that referenced
this pull request
Aug 21, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Oct 27, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Dec 20, 2023
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: llvm#221
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: llvm#221
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b84865c1ad51c72efbe3486be18eddeea4c Pull Request resolved: llvm/clangir#221
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: llvm#221
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: llvm#221
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This replaces the usage of attributes for zero-initializing global variables, with a more robust zero-initialization op-based method (cir.llvmir.zeroinit). The downside of this approach is that is not as compact or efficient as the attribute-based method, however: - Both are temporary solutions, but it's easier to track and patch the usage of a single op than an attribute in any op. - Attribute-based method is more difficult to lower, requiring more maintenance. - Op-based method may require a region, but it will populate the region with at most a couple of operations. ghstack-source-id: 4f239b8 Pull Request resolved: #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This replaces the usage of attributes for zero-initializing global
variables, with a more robust zero-initialization op-based method
(cir.llvmir.zeroinit).
The downside of this approach is that is not as compact or efficient as
the attribute-based method, however:
the usage of a single op than an attribute in any op.
maintenance.
with at most a couple of operations.