Skip to content

Conversation

@jiang1997
Copy link

Fix #1868

@jiang1997 jiang1997 force-pushed the fix-#1868 branch 2 times, most recently from 5b25f33 to af464b6 Compare October 26, 2025 19:20
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Almost good, some issues need addressing!

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiang1997 jiang1997 force-pushed the fix-#1868 branch 2 times, most recently from 6e83ac5 to 7e9639a Compare November 4, 2025 19:17
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor nits remaining

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions cpp,c,h -- clang/test/CIR/CodeGen/scoped-atomic-load-store.c clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h clang/include/clang/CIR/MissingFeatures.h clang/lib/CIR/CodeGen/CIRGenAtomic.cpp clang/lib/CIR/CodeGen/CIRGenBuilder.h clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp clang/lib/CIR/CodeGen/CIRGenBuiltinAArch64.cpp clang/lib/CIR/Dialect/IR/CIRDialect.cpp clang/lib/CIR/Dialect/Transforms/TargetLowering/ItaniumCXXABI.cpp clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRLoopToSCF.cpp clang/test/CIR/CodeGen/AArch64/neon-ldst.c
View the diff from clang-format here.
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 3a101a1fdc..16e1c052ca 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -1024,9 +1024,7 @@ void cir::LoadOp::setAtomic(cir::MemOrder order, cir::SyncScopeKind scope) {
 
 // TODO(CIR): The final interface here should include an argument for the
 // SyncScope::ID.
-void cir::StoreOp::setAtomic(cir::MemOrder order) {
-  setMemOrder(order);
-}
+void cir::StoreOp::setAtomic(cir::MemOrder order) { setMemOrder(order); }
 
 //===----------------------------------------------------------------------===//
 // VecCreateOp

@bcardosolopes
Copy link
Member

Seems like there's also some bad formatting needing fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cir.load does not have scoped atomic support

3 participants