[CIR] Refactor cir.cast to use uniform assembly form w/o parens, commas #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format now has the following assembly form:
$kind $src : type($src) -> type($result) attr-dict
This unifies CIR operation formats by removing unnecessary parentheses
and using `->` consistently to denote result types.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xlauko
requested review from
andykaylor,
bcardosolopes and
lanza
as code owners
bcardosolopes
approved these changes
Sep 29, 2025
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Sep 30, 2025
This mirrors incubator changes from llvm/clangir#1922
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 1, 2025
This mirrors incubator changes from llvm/clangir#1922
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 1, 2025
This mirrors incubator changes from llvm/clangir#1922
kraj
pushed a commit
to kraj/llvm-project
that referenced
this pull request
Oct 1, 2025
This mirrors incubator changes from llvm/clangir#1922
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 1, 2025
…as (#161431) This mirrors incubator changes from llvm/clangir#1922
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 1, 2025
…arens, commas (#161431) This mirrors incubator changes from llvm/clangir#1922
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…as (llvm#161431) This mirrors incubator changes from llvm/clangir#1922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format now has the following assembly form:
$kind $src : type($src) -> type($result) attr-dictThis unifies CIR operation formats by removing unnecessary parentheses
and using
->consistently to denote result types.