[CIR][CodeGen] Implement tryMarkNoThrow and update wrong test #1664
Conversation
| if (isInterposable(fn)) | ||
| return; | ||
|
|
||
| for (auto &blk : fn.getBlocks()) { |
There was a problem hiding this comment.
Instead of walking the function here (which could be expensive), we could keep some state in cgf to track when those operations are emitted, then you could change this function to just check that state and go about the business of adding attributes. How does that sound?
There was a problem hiding this comment.
Sounds good! I will update the PR next week.
There was a problem hiding this comment.
@bcardosolopes updated)
Sounds good enough, perhaps as you add the |
) This PR introduces [`TryMarkNoThrow`](https://github.com/llvm/clangir/blob/6e5fa09550c98f84d017873ed3e5667fd5fd909c/clang/lib/CodeGen/CodeGenFunction.cpp#L1394). [`isInterposable`](https://github.com/llvm/clangir/blob/6e5fa09550c98f84d017873ed3e5667fd5fd909c/clang/lib/CodeGen/CodeGenFunction.cpp#L1397C10-L1397C26) isn't fully implemented and I'm not quite sure we need it? Anyway, I have introduced a missing feature `getSemanticInterposition` relevant for its completion. I have also updated an old test -- [`foo()`](https://github.com/llvm/clangir/blob/6e5fa09550c98f84d017873ed3e5667fd5fd909c/clang/test/CIR/CodeGen/try-catch-dtors.cpp#L313) should be marked as unwind/nothrow. I have compared with the original CodeGen and attached the llvm output for verification. One concern I have is if the cases I have to mimic [`mayThrow`](https://github.com/llvm/clangir/blob/6e5fa09550c98f84d017873ed3e5667fd5fd909c/llvm/lib/IR/Instruction.cpp#L1158) from the OG are enough, please let me know your thoughts.
2 participants
This PR introduces
TryMarkNoThrow.isInterposableisn't fully implemented and I'm not quite sure we need it? Anyway, I have introduced a missing featuregetSemanticInterpositionrelevant for its completion.I have also updated an old test --
foo()should be marked as unwind/nothrow. I have compared with the original CodeGen and attached the llvm output for verification.One concern I have is if the cases I have to mimic
mayThrowfrom the OG are enough, please let me know your thoughts.