Update on "[CIR] Add reconcile unrealized casts pass"

[ghstack-poisoned]

Author: sitio-couto

clang/lib/CIR/CodeGen/CIRGenBuilder.h

@@ -23,6 +23,7 @@
 #include "mlir/IR/Builders.h"
 #include "mlir/IR/BuiltinAttributes.h"
 #include "mlir/IR/BuiltinTypes.h"
+#include "llvm/ADT/APSInt.h"
 #include "llvm/ADT/FloatingPointMode.h"
 #include "llvm/Support/ErrorHandling.h"
 
@@ -286,6 +287,13 @@ class CIRGenBuilderTy : public mlir::OpBuilder {
                                     uint64_t C) {
     return create<mlir::cir::ConstantOp>(loc, t, mlir::cir::IntAttr::get(t, C));
   }
+  mlir::cir::ConstantOp getConstInt(mlir::Location loc, llvm::APSInt intVal) {
+    bool isSigned = intVal.isSigned();
+    auto width = intVal.getBitWidth();
+    mlir::cir::IntType t = isSigned ? getSIntNTy(width) : getUIntNTy(width);
+    return getConstInt(
+        loc, t, isSigned ? intVal.getSExtValue() : intVal.getZExtValue());
+  }
   mlir::cir::ConstantOp getBool(bool state, mlir::Location loc) {
     return create<mlir::cir::ConstantOp>(loc, getBoolTy(),
                                          getCIRBoolAttr(state));

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp

@@ -186,9 +186,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
     llvm_unreachable("NYI");
   }
   mlir::Value VisitOffsetOfExpr(OffsetOfExpr *E) { llvm_unreachable("NYI"); }
-  mlir::Value VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *E) {
-    llvm_unreachable("NYI");
-  }
+  mlir::Value VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *E);
   mlir::Value VisitAddrLabelExpr(const AddrLabelExpr *E) {
     llvm_unreachable("NYI");
   }
@@ -2152,3 +2150,23 @@ mlir::Value ScalarExprEmitter::VisitVAArgExpr(VAArgExpr *VE) {
 
   return Val;
 }
+
+/// Return the size or alignment of the type of argument of the sizeof
+/// expression as an integer.
+mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
+    const UnaryExprOrTypeTraitExpr *E) {
+  QualType TypeToSize = E->getTypeOfArgument();
+  if (E->getKind() == UETT_SizeOf) {
+    if (const VariableArrayType *VAT =
+            CGF.getContext().getAsVariableArrayType(TypeToSize)) {
+      llvm_unreachable("NYI");
+    }
+  } else if (E->getKind() == UETT_OpenMPRequiredSimdAlign) {
+    llvm_unreachable("NYI");
+  }
+
+  // If this isn't sizeof(vla), the result must be constant; use the constant
+  // folding logic so we don't have to duplicate it here.
+  return Builder.getConstInt(CGF.getLoc(E->getSourceRange()),
+                             E->EvaluateKnownConstInt(CGF.getContext()));
+}

clang/test/CIR/CodeGen/basic.cpp

@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir-enable -emit-cir %s -o %t.cir
+// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir-enable -emit-cir %s -o %t.cir
 // RUN: FileCheck --input-file=%t.cir %s
 
 int *p0() {
@@ -162,6 +162,21 @@ void x() {
 // CHECK:   %3 = cir.const(#false) : !cir.bool
 // CHECK:   cir.store %3, %1 : !cir.bool, cir.ptr <!cir.bool>
 
+typedef unsigned long size_type;
+typedef unsigned long _Tp;
+
+size_type max_size() {
+  return size_type(~0) / sizeof(_Tp);
+}
+
+// CHECK: cir.func @_Z8max_sizev()
+// CHECK:   %0 = cir.alloca !u64i, cir.ptr <!u64i>, ["__retval"] {alignment = 8 : i64}
+// CHECK:   %1 = cir.const(#cir.int<0> : !s32i) : !s32i
+// CHECK:   %2 = cir.unary(not, %1) : !s32i, !s32i
+// CHECK:   %3 = cir.cast(integral, %2 : !s32i), !u64i
+// CHECK:   %4 = cir.const(#cir.int<8> : !u64i) : !u64i
+// CHECK:   %5 = cir.binop(div, %3, %4) : !u64i
+
 // CHECK-DAG: #[[locScope]] = loc(fused[#[[locScopeA:loc[0-9]+]], #[[locScopeB:loc[0-9]+]]])
 // CHECK-DAG: #[[locScopeA]] = loc("{{.*}}basic.cpp":27:3)
 // CHECK-DAG: #[[locScopeB]] = loc("{{.*}}basic.cpp":31:3)