Update on "[CIR] Add reconcile unrealized casts pass"

[ghstack-poisoned]

Author: sitio-couto

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -126,6 +126,10 @@ class CIRLoopOpLowering : public mlir::OpConversionPattern<mlir::cir::LoopOp> {
           return mlir::failure();
       }
     }
+
+    // Succeed only if both yields are found.
+    if (!yieldToBody || !yieldToCont)
+      return mlir::failure();
     return mlir::success();
   }
 
@@ -142,7 +146,7 @@ class CIRLoopOpLowering : public mlir::OpConversionPattern<mlir::cir::LoopOp> {
     auto &condFrontBlock = condRegion.front();
     mlir::cir::YieldOp yieldToBody, yieldToCont;
     if (fetchCondRegionYields(condRegion, yieldToBody, yieldToCont).failed())
-      loopOp.emitError("invalid yield op kind in cond region");
+      return loopOp.emitError("failed to fetch yields in cond region");
 
     // Fetch required info from the condition region.
     auto &bodyRegion = loopOp.getBody();