Redo the Pass Manager #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/LLVM/PassPipeliner.swift
Outdated
| .globalDCE, | ||
| .deadArgElimination, | ||
| .ipConstantPropagation, | ||
| .ipscc: |
There was a problem hiding this comment.
I believe at least .functionAttrs should be here too.
CodaFi
force-pushed
the
dont-pass-me-by
branch
3 times, most recently
from
51711ec to
6c35b53
Compare
| @@ -106,8 +106,6 @@ public enum FunctionPass { | |||
| case scalarReplAggregates | |||
| /// Replace aggregates or pieces of aggregates with scalar SSA values. | |||
| case scalarReplAggregatesSSA | |||
| /// Tries to inline the fast path of library calls such as sqrt. | |||
| case simplifyLibCalls | |||
There was a problem hiding this comment.
Why is this removed?
There was a problem hiding this comment.
The corresponding add pass function is a no-op as the pass has been removed.
All the SROA variants in the C API no longer make a difference.
This finally allows us to wrap passes that require additional parameters or configuration calls. In order to do this for internalize in particular, we have to do some heroic lifetime juggling.
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This thing was never correct. We mixed up Function passes and Module passes, and if you were unlucky enough to schedule both into the function pass manager then LLVM would probably crash.
Provide the interface we were shooting for here anyways in the form of a Swift-like pass pipeliner. You can freely mix module and function-level passes in the pipeliner, and we will schedule them the way LLVM would anyways (group the function passes, then run the module passes). There's bindings for LTO passes that never made it into a header that we could also wrap with this infrastructure.