Skip to content

update for swift 4.1 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2018
Merged

update for swift 4.1 #135

merged 3 commits into from
Apr 16, 2018

Conversation

edwardvalentini
Copy link
Contributor

just updating make-pkgconfig.swift to use compactMap instead of flapMap for swift 4.1

@harlanhaskins
Copy link
Member

Thank you! Until Travis CI supports Xcode 9.3,

@harlanhaskins
Copy link
Member

Oops, please ignore. Sorry, got half way through a comment and hit the wrong button.

@CodaFi
Copy link
Member

CodaFi commented Apr 15, 2018

Hello, thank you for the change.

In order to land this, you'll need to update the Travis build script to point at Swift 4.1. Before you do that, I have a request: #95 is where we disabled the Linux build because of an unfortunate oversight in the build script. If you could, let me know if you'd be willing to look into re-enabling that build configuration for 4.1. It's entirely optional, but it would be a huge help if you could.

@edwardvalentini
Copy link
Contributor Author

sure i can definitely take a look at the travis build script.

@CodaFi
Copy link
Member

CodaFi commented Apr 16, 2018

Holy cow, that worked like a charm. ✨

Thank you so very very much. I'm going to release this as a new version of LLVMSwift.

⛵️

@CodaFi CodaFi merged commit e7c190e into llvm-swift:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants