Skip to content

Added logic to generate Python binding source modules/C++ files.#14

Open
pbtoast wants to merge 2 commits into
masterfrom
pybind11-deps
Open

Added logic to generate Python binding source modules/C++ files.#14
pbtoast wants to merge 2 commits into
masterfrom
pybind11-deps

Conversation

@pbtoast

@pbtoast pbtoast commented Mar 15, 2019

Copy link
Copy Markdown
Collaborator

This change includes code to generate dependencies for generated Python bindings. It uses Python 3's print() function to emit dependencies into a CMake variable, so we need to convert that print statement to Python 2 before this can go in.

@pbtoast pbtoast added the python label Mar 15, 2019
@pbtoast
pbtoast requested a review from jmikeowen March 15, 2019 21:52
@pbtoast

pbtoast commented Mar 15, 2019

Copy link
Copy Markdown
Collaborator Author

I changed the print to Python 2, so maybe @jmikeowen here can test it out and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant