Fix crash querying whether an exec space uses an allocator id. #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should return false for invalid allocator id.
gunney1
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
kennyweiss and
publixsubfan
This was referenced Sep 21, 2025
kennyweiss
approved these changes
Sep 22, 2025
src/axom/core/memory_management.hpp
Outdated
| * For Umpire allocator ids, the MemorySpace is the Umpire memory | ||
| * space. For MALLOC_ALLOCATOR_ID, the MemorySpace is | ||
| * MemorySpace::Malloc. Other values have no corresponding MemorySpace | ||
| * and will cause an unrecoverable exception. |
Member
There was a problem hiding this comment.
Clarify: It's calling processAbort -- is it fair to call that an unrecoverable exception? Please consider rephrasing.
gunney1
added
bug
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can query whether an execution space uses a certain axom allocator id. If we pass the invalid allocator id, it crashes. This fixes the code to return false instead of crashing.
PR #1654 depends on this one.