Skip to content

Conversation

@rchen20
Copy link
Member

@rchen20 rchen20 commented Dec 10, 2025

Summary

  • This PR is a refactoring
  • It does the following:
    • Refactors FEMSWEEP to read in a file to populate mesh connectivity data.

@MrBurmark
Copy link
Member

Does reading the data also affect the problem size, number of elements, etc?

@artv3
Copy link
Member

artv3 commented Dec 19, 2025

How big can meshes get? I'm wondering how the meshes will impact the repo size.

@rchen20 rchen20 changed the title DRAFT: Change FEMSWEEP to read in file for mesh data Change FEMSWEEP to read in file for mesh data Jan 6, 2026
@artv3 artv3 self-requested a review January 16, 2026 18:57
}

template < typename T >
void FEMSWEEP::readIndexArray(VariantID vid, std::ifstream & file, T*& arr, Index_type expectedsize, std::string arrname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be a free function, probably in an unnamed namespace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move it if some other kernel is going to use it, but I think the femsweep is the only one that requires something like this at the moment so I'll keep it the way it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean that it doesn't use any of the kernel's state, it could be a free function. Its not a big deal, but its probably best practice if that's true to make it a free function.

@pearce8 pearce8 mentioned this pull request Jan 16, 2026
3 tasks
@rchen20
Copy link
Member Author

rchen20 commented Jan 20, 2026

@rhornung67 How about I revert this PR such that there is only one small mesh? That way the meshes won't show up in the git branches and history. After that, we can create another repo to store the larger meshes.

@artv3
Copy link
Member

artv3 commented Jan 20, 2026

@rchen20 , you can also squash merge

@rchen20
Copy link
Member Author

rchen20 commented Jan 20, 2026

@rchen20 , you can also squash merge

Thanks, but I don't think squash merging will prevent people from downloading all the meshes on every git clone. I'd need to remove the meshes from the history entirely.

@artv3
Copy link
Member

artv3 commented Jan 20, 2026

@rchen20 , you can also squash merge

Thanks, but I don't think squash merging will prevent people from downloading all the meshes on every git clone. I'd need to remove the meshes from the history entirely.

Ah I see, thanks for explaining. Sure I'm in favor of your original proposition

@rchen20 rchen20 force-pushed the task/chen59/femsweepmeshfile branch from a5e122b to 0a3a53a Compare January 21, 2026 00:33
@rchen20 rchen20 enabled auto-merge January 22, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants