Skip to content

Conversation

@rhornung67
Copy link
Member

Summary

RELEASE_NOTES.md Outdated
Comment on lines 33 to 34
* Add Kahan sum class used internally to make parallel sum reductions
more accurate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add Kahan sum class used internally to make parallel sum reductions
more accurate
* Add Kahan sum class used in RAJAPerf to make parallel sum reductions
more accurate, note that using fast-math (default with intel) will undo
the accuracy increase

Copy link
Member

@smithsg84 smithsg84 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Intel in suggested change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithsg84 @MrBurmark I made your suggested changes. Please take a look ASAP and let me know if you are good with this. Thank you.

@MrBurmark MrBurmark self-requested a review January 28, 2026 23:47
RELEASE_NOTES.md Outdated
Comment on lines 33 to 34
* Add Kahan sum class used internally to make parallel sum reductions
more accurate
Copy link
Member

@smithsg84 smithsg84 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize Intel in suggested change.

@rhornung67 rhornung67 closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants