Remove warning supressions #1956
Merged
+114
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
requested review from
MrBurmark,
artv3,
johnbowen42,
rchen20 and
rhornung67
rhornung67
approved these changes
Dec 11, 2025
Member
rhornung67
left a comment
rhornung67
left a comment
There was a problem hiding this comment.
@MrBurmark do you know if the nvcc compiler has improved so that these macros are no longer needed?
Member
|
Do these actually need to be host device? They do make omp calls... |
artv3
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge #1947 merge broke builds on LC matrix and other CUDA builds.
Remove the suppression warnings.
This fixes #1954