Resource Integration #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/tpl/umpire tests/unit/CMakeLists.txt
…CHAI into feature/device-context-integration Conflicts: examples/context.cpp
…CHAI into feature/device-context-integration
…om/llnl/CHAI into feature/device-context-integration
adayton1
reviewed
Apr 14, 2023
adayton1
reviewed
Apr 14, 2023
adayton1
reviewed
Apr 14, 2023
adayton1
reviewed
Apr 14, 2023
src/chai/ArrayManager.cpp
Outdated
|
|
||
| camp::resources::Resource* res; | ||
| if (space == chai::CPU){ | ||
| res = record->m_last_resource; |
Member
There was a problem hiding this comment.
It seems weird that we might ignore the resource passed in.
adayton1
reviewed
Apr 24, 2023
| @@ -830,7 +830,9 @@ GPU_TEST(ManagedArray, PodTestGPU) | |||
|
|
|||
| TEST(ManagedArray, ExternalConstructorUnowned) | |||
Member
There was a problem hiding this comment.
@davidbeckingsale, @mdavis36, I can't get this test to pass.
Member
There was a problem hiding this comment.
It also seems that using pinned memory for the CPU space conflicts with the ability to construct using a simple malloc'ed pointer (say from a 3rd party library).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for streaming context resources to work with Chai/Umpire/Camp. Current support added for host devices, cuda devices and asynchronous data migration from GPU to Host.
This new feature is demonstrated in new examples using Chai forall utility.