Conversation
dawson6
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option, that works under the Flux scheduler, to allow users to run tests on the same node. It is a per-test option where a string is specified and tests with the same string will be run on the same node. Setting this option will limit the number of nodes you can use for the test to one (-N1) and the number of cores to the maximum on the node (-nMAX), if the user requests more cores than on the node, otherwise -n stays the same.
This PR will close: #103
Note: while this is an option working under Flux, we do have Flux working under slrum.
This PR also adds documentation for two previously added command line options: removeStartNote and removeEndNote.