Update llm-jp-tokenizer tag to the latest for cloning #12
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,9 @@ export PRETRAIN_TORCHVISION_VERSION=0.18.1 | |||||||||
| export PRETRAIN_APEX_VERSION=24.04.01 | ||||||||||
| export PRETRAIN_TRANSFORMER_ENGINE_VERSION=1.4 | ||||||||||
| export PRETRAIN_MEGATRON_TAG=nii-geniac | ||||||||||
| # Ensure the appropriate Huggingface tokenizer is included | ||||||||||
| # https://github.com/llm-jp/scripts/pull/12#discussion_r1708415209 | ||||||||||
| export PRETRAIN_TOKENIZER_TAG=v3.0b2 | ||||||||||
ytivy marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
|
|
||||||||||
|
Comment on lines
+20
to
21
Contributor
Author
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. 今対応してしまった方が良さそうなので書いてみました
Member
There was a problem hiding this comment. @YumaTsuta ちょうど蔦さんのコメントへのリンクが取れるので、これをコメントに追加しておくのが親切だと思いました。 |
||||||||||
| module load cuda/${PRETRAIN_CUDA_VERSION} | ||||||||||
| module load /data/cudnn-tmp-install/modulefiles/${PRETRAIN_CUDNN_VERSION} | ||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ablationシート
の18-19行目では学習に3.0b1を使用し、評価に3.0b2を使用することになっています。こちらの設定は学習用なので、変更不要に見えます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントが足りていませんでした。
Megatron -> HFのconvert時にHFのtokenizerを指定する必要があり、Release-ver3.0b1では修正版のv3.0b2 (hf tokenizer) が含まれていません。
convert スクリプトではMagatron-LMのスクリプトをベースとするため、事前学習モデルの環境構築スクリプトを利用しており、こちらの修正PRを出しました
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど、了解です。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approveしましたが、上記はスクリプトにコメントが書いてあった方がよいかもしれません。