-
Notifications
You must be signed in to change notification settings - Fork 105
test: Enable running the end to end tests on K8S clusters other than Kind #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hdefazio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few makefile targets have envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION'
Do we need to remove $IMAGE_TAG_BASE and/or add the new image env vars to this?
|
scripts/kind-dev-env.sh and scripts/kubernetes-dev-env.sh can also be updated to use EPP_IMAGE /SIDECAR_IMAGE /VLLM_SIMULATOR_IMAGE |
Both have been fixed. |
07322f2 to
03ea49c
Compare
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
caf3b8c to
a5deb8a
Compare
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this seems like an unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're fundamentally correct. But upstream, the function LoadConfig no longer exists causing lint to fail in the file test/config/prefix_cache_mode_test.go. I then searched for LoadConfig and updated all references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're fundamentally correct. But upstream, the function LoadConfig no longer exists causing lint to fail.
|
/unhold |
This PR enables the running of the End to End tests on clusters other than kind.
If the environment variable
K8S_CONTEXTis set the end to end test code will not create a kind cluster for the test. Instead the cluster pointed to by the specified context in the current Kubernetes Config will be used. All created Kubernetes objects will be deleted at the end of the test. Additionallykubectl port-forwardwill be started to enable the tests to be run from "outside" the target cluster. The user running the tests, needs to be a cluster wide admin for the cluster in question.In addition the following environment variables can "configure" the tests if needed:
E2E_PORT- the local port used to send the inference requests to.NAMESPACE- the Kubernetes namespace to create all of the namespaced objects in.EPP_IMAGE- the full image name to be used for the llm-d-inference-schedulerSIDECAR_IMAGE- the full image name for the llm-d-routing-sidecarVLLM_SIMULATOR_IMAGE- the full name for the llm-d-inference-sim