Refactor Redis configuration handling in KV cache scorer #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct Redis address assignment with URL parsing for better configuration management. This ensures proper error handling and compatibility with Redis connection options. Added Redis client dependency to facilitate this change.
Open
1 task
|
Depends on: llm-d/llm-d-kv-cache-manager#37 Going to do custom build where I replace current kv-cache-manager and ensure the current strategy of specifying redis Addresses is not broken and I can successfully deploy the inference-scheduler and connect it to a redis deployment with authentication enabled over TLS. |
relyt0925
force-pushed
the
redis-auth-support
branch
from
58db67f to
3481388
Compare
relyt0925
force-pushed
the
redis-auth-support
branch
from
3481388 to
421b495
Compare
|
I did need to add logic to keep the current path of specifying "hostname:port" still functional without regressions. When that is specified (specifically no protocol prefix is specified): the url string will assume it is redis:// protocol: which is in line with all existing references. My custom build was successful otherwise. |
|
Thank you @relyt0925 - merged your PR and tagged (v0.1.1). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace direct Redis address assignment with URL parsing for better configuration management. This ensures proper error handling and compatibility with Redis connection options. Added Redis client dependency to facilitate this change.