Skip to content

QueueItUp for Framepack mod adds queueing, batching, prompt saving, and many ui tweeks #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

chuckkay
Copy link

@chuckkay chuckkay commented Apr 21, 2025

Do not consider this a one feature pull request anymore as i will be working on my fork more extensively with many new and many enhanced features. The new fork will be called QUEUEITUP For Framepack. Enjoy

@chuckkay
Copy link
Author

from the guy who brought you QueueItUp for Facefusion, her is QueueItUp WanGP

cleaned up debugging from pull request
@zadokov
Copy link

zadokov commented Apr 21, 2025

@chuckkay - Is there a way to delete a specific item from the queue? Or add such functionality if not exist?

@chuckkay
Copy link
Author

chuckkay commented Apr 22, 2025

@chuckkay - Is there a way to delete a specific item from the queue? Or add such functionality if not exist?

not yet... working on ability to delet a spacific job from the queue... i can do the code very easily but because of gradio limitations the GUI would be terrible, basically a dropdown list and you would have to guess which one you are looking to delete without visual thumbnail to know for sure. but in the mean time you can always manually remove it from the job_queue.json file

@chuckkay
Copy link
Author

Screenshot 2025-04-21 205415

@chuckkay
Copy link
Author

Screenshot 2025-04-21 210410

now instead of being limited to uploading one input image, you can add multiple images to the prompt, and it will create a job for each image using the same prompt and settings, plus i added more gui improvements to thumbnails.
@chuckkay
Copy link
Author

Screenshot 2025-04-22 032307

@a-l-e-x-d-s-9
Copy link

Queue is a great functionality to have.
Thank you very much for implementing the basic functionality!
I have been testing it in the last couple days.
A few things that I have noticed:

  1. After a particular job started it's no longer showing the image in the Job Queue - only prompt text.
  2. There is no option to reorder jobs - it would be really helpful to have it.
  3. There is no way to cancel running job, only "End Generation" that would cancel everything.
  4. There is no way to remove a job from Job Queue.
  5. Is it possible to adjust jobs parameters after adding them to Job Queue? Maybe I missed it.
  6. Source images can be dragged only once, if trying to drag another one after that, it's not working.
    Hopefully this PR will be added to repository and the missing features will be implemented as well.

@chuckkay
Copy link
Author

Queue is a great functionality to have. Thank you very much for implementing the basic functionality! I have been testing it in the last couple days. A few things that I have noticed:

  1. After a particular job started it's no longer showing the image in the Job Queue - only prompt text.
  2. There is no option to reorder jobs - it would be really helpful to have it.
  3. There is no way to cancel running job, only "End Generation" that would cancel everything.
  4. There is no way to remove a job from Job Queue.
  5. Is it possible to adjust jobs parameters after adding them to Job Queue? Maybe I missed it.
  6. Source images can be dragged only once, if trying to drag another one after that, it's not working.
    Hopefully this PR will be added to repository and the missing features will be implemented as well.

great points, some i am working on, and some are new good ideas. and some have me stumped because gradio is limited and a pain in the ass. rest assured i am working on all of them. keep in mind it is not guaranteed that the job_queue.json and quick_prompts.json files will be compatible from version to version with all the changes im making. always best to delete those 2 files manually if you are experiencing errors or annomalies after updated between version of my demo_gradio.py mod.

some webui tweaks and restored previously "not used" negative prompt, don't know if it helps or not, but it's there now, and can be saved in the quick list with the prompt.
@chuckkay chuckkay changed the title added queueing and prompt saving added queueing, batching, prompt saving, and many ui tweeks Apr 23, 2025
@Kryptortio
Copy link

Did you miss this #150 pull request? Since that one already implemented a queue I think you should add a motivation if you think a different implementation is needed. Otherwise it might be better to focus work on that one because at a glance it seems to have more features (reorder, remove, load, save, clear) some of which were also requested here.

don't know why framepack leaves leftover shorter versions of the video, this will by default delete these temp mp4s and also delete the temp png file from the output folder
@tin2tin
Copy link

tin2tin commented Apr 24, 2025

@chuckkay Thank you for this convenient batch extension. One question: does it automatically save the generated video files, and if so, where are they saved?

Ah, in: \framepack_cu126_torch26\webui\outputs

@chuckkay
Copy link
Author

just added job deletion and job reordering.... i think im done now, this was a proof of concept, that i just kept adding tweaks and enhancements to, i hope developer will incorporate these features into official version, until then feel free to use this for queueing and batching.

@tin2tin
Copy link

tin2tin commented Apr 24, 2025

@chuckkay Tried hot fix 3 - and it still broken.

@tin2tin
Copy link

tin2tin commented Apr 24, 2025

@chuckkay The Queuing Order needs to be reset when Delete All Jobs

@chuckkay chuckkay changed the title added queueing, batching, prompt saving, and many ui tweeks QueueItUp for Framepack mod adds queueing, batching, prompt saving, and many ui tweeks Apr 24, 2025
@chuckkay
Copy link
Author

Fyi no updates for 24 hours, currently running a queue of 125 jobs lol.... can't wait to see what the authors and others come up with, when it come to features and improvements, if nothing by the weekend i will try to consolidate some of the better features into my mod by Sunday.

@chuckkay
Copy link
Author

@chuckkay Tried hot fix 3 - and it still broken.

Current version works very well for me. Try deleting job_queue.json and quick_prompts.json and restart...

@a-l-e-x-d-s-9
Copy link

I updated and got this error:

File "/home/alexds9/Documents/stable_diffusion/FramePack/demo_gradio.py", line 1694, in <module>
    default_prompt, default_n_prompt, default_length, default_gs = get_default_prompt()
ValueError: not enough values to unpack (expected 4, got 3)

@chuckkay
Copy link
Author

Did you miss this #150 pull request? Since that one already implemented a queue I think you should add a motivation if you think a different implementation is needed. Otherwise it might be better to focus work on that one because at a glance it seems to have more features (reorder, remove, load, save, clear) some of which were also requested here.

Yes i missed it and have now incorporated it's approach to ordering the queued jobs using a gradio datafield approach. I personally think my version is better because of all the other features queuing, UI and GUI features i offer, and also because it keeps the running job always at the top and completed jobs always at the bottom. All other jobs are movable up down and can also be moved to be first or last in the queue.

@chuckkay
Copy link
Author

I updated and got this error:


File "/home/alexds9/Documents/stable_diffusion/FramePack/demo_gradio.py", line 1694, in <module>

    default_prompt, default_n_prompt, default_length, default_gs = get_default_prompt()

ValueError: not enough values to unpack (expected 4, got 3)

Probably an old job created in a previous version is in your jobs_queue.json file. Deleting The job or entire json file will fix it.

@a-l-e-x-d-s-9
Copy link

The function wasn't returning the default empty negative prompt, code was expecting to get 4 return values, but got only 3. It was easy to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants