-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lcm realtime canvas painting #1043
base: main
Are you sure you want to change the base?
Conversation
requires fix of gradio-app/gradio#5019, which is available from 3.45.0, but 3.50.2 is also compatible
prevents queue spam for too many updates
This feature will cause the shortcut for inpaint to become invalid after updating gradio, and images in the gallery cannot be clicked for fullscreen. |
@diaolulu1 thank you for pointing that out, will try to check it with gradio v3.45.0. Please keep me posted if you already tried this version. |
I tried your enhancement, that's excellent! Thanks for your contribution.
|
@thiner this feature might already be superseded by SDXL Turbo.
|
@diaolulu1 there is a hardcoded svelte class which changed after updating gradio. |
I've tried the latest modification, the shortcut issue with the inpaint canvas has been fixed, but the images in the gallery preview window still can't be fullscreened after clicking. |
At the start of each drawing session, Fooocus loads the model into the VRAM, which certainly wastes time. Is it possible to keep the model constantly in VRAM when in the realtime canvas mode? |
It seems unnecessary to upgrade gradio to 3.50.2 as the live canvas still operates normally and all bugs are non-existent. |
I have encountered a problem on the server side with this Gradio upgrade. The issue is the same as #728 (comment) |
@diaolulu1 yes, this is indeed possible. As mentioned in the PR description it is advised to use the argument --highvram to keep the model in VRAM and reduce generaton time. Please give it a shot. Upgrading Gradio is necessary (at least to 3.45.0) as only updated versions include support for updating image shape. @thiner ok, then let's downgrade to 3.45.0 |
I've found that the resolution of the real-time canvas doesn't change when I modify the resolution settings. |
@diaolulu1 tested it on mobile and desktop viewports in both Chrome and Firefox and all combinations are working fine. |
It was my mistake, my gradio was still at version 3.41.2. My issue is now resolved, thank you very much! |
…ltime-canvas # Conflicts: # webui.py
# Conflicts: # webui.py
простите, уважаемые, вы где такие версии нашли > 3.41.0 ? Aug 24, 2023 |
Fixes #990
This feature introduces a new tab with a canvas to act as alternative input for uov_input_image with vary strong.
It's recommended to use this with arg
--highvram
to further reduce generation time.