SVG output now supports width and height attibute on top-level SVG ele… #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalqb
changed the title
|
Hi @fractalqb, |
|
I had a look at the commits but I couldn't find any comments. As I said, I'm not (yet) a github Pro! |
llgcode
reviewed
Jul 11, 2019
draw2dsvg/svg.go
Outdated
| @@ -35,6 +35,8 @@ const ( | |||
| type Svg struct { | |||
| XMLName xml.Name `xml:"svg"` | |||
| Xmlns string `xml:"xmlns,attr"` | |||
| Width float64 `xml:"width,attr,omitempty"` | |||
There was a problem hiding this comment.
I think Width and Height must have string type I guess cause you can have some css unit in it. See Dimension type below.
There was a problem hiding this comment.
You are completely right and I was only going for some quick results. I changed it in my fork. Hope it's OK for a pull now.
According to the SVG specification the sizing properties "width" and "height" can have non-numerical values like "auto" or "128px". To support this SVG feature the type of the respective values of the svg element is changed to string.
|
It looks ok for me, thanks @fractalqb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #152