Darwin fixes #390
Merged
Darwin fixes #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
Thanks! I didn't change the version in pubspec.yaml to 1.1.3 as I wasn't sure if you were ready to release yet. We look forward to having the changes in a published version. Is that something you are ready to do? |
|
I may tackle some more issues on darwin package before publishing. |
|
That sounds good. I just have a |
|
I agree, if other fixes take me too far I will publish. |
|
Released in 1.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Exception where format.sampleRate != hwFormat.sampleRate
This patch fixes an exception that crashes the app. The exception is caused by a wrong source audio format being used for the installTap call on the input. Instead of the inputFormat being used, the outputFormat was used which caused the exception when some devices are selected.
feat(macOS): Support device by deviceID as well as deviceUID
For compatibility with other packages which may report devices by their deviceID rather than deviceUID. The flutter_webrtc package is an example. This patch will match on either. There is no overlap so the old behavior should not be impacted.