Merged
Conversation
|
🚅 Deployed to the positivehelp-pr-208 environment in rare-vitality
|
Resolve all Biome lint warnings to maintain code quality standards. ### Code Quality Improvements - **lib/tokens.ts**: Use node: protocol for crypto import - **app/api/tokens/[id]/route.ts**: Replace isNaN() with Number.isNaN() - **scripts/delete-message.ts**: Replace isNaN() with Number.isNaN() - **app/og/[slug]/route.tsx**: Use type import for NextRequest, prefix unused param with underscore - **middleware.ts**: Prefix unused request param with underscore - **app/submissions/submissions-table.tsx**: Prefix unused type param with underscore - **lib/client-error-handler.ts**: Replace any[] with unknown[] for better type safety - **lib/seo.ts**: Replace any with Record<string, unknown> for structured data - **lib/rate-limit.ts**: Remove unused remaining variable from destructure - **__tests__/lib/env.test.ts**: Remove unused z import from zod ### Configuration - **biome.json**: Bump schema version from 2.3.14 to 2.4.0
Expand CI workflow to run linting in parallel with tests. This ensures code quality standards are enforced on all pull requests and pushes to main branch. ### CI Improvements - **.github/workflows/test.yml**: Add lint job that runs Biome linting - **.github/workflows/test.yml**: Update workflow name from "CI - Run Unit Tests" to "CI" - **.github/workflows/test.yml**: Configure lint job with pnpm 10.12.1 and Node.js 22.x ### Benefits - Catches linting errors earlier in the development cycle - Runs in parallel with test matrix for faster feedback - Uses frozen lockfile for reproducible builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check,ship, andsuggest-commitJust tasks to run CI, close/sync tracker work, and recommend commits during maintenance runsupdate-pr-descriptionskill instructions for future PR refreshesTesting