OPENSSL_SSLV23_PADDING is optional

[remicollet]

When build with new OpenSSL 3.0

See php/php-src@a0972de#diff-c85372ee14ed2a3e599bc555e3d245e4cd654e4a57f250ba927701dd8b61d102

There was 1 failure:
1) Bartlett\CompatInfoDb\Tests\Reference\Extension\PhpBundle\Openssl\OpensslExtensionTest::testGetConstantsFromReference
Constant 'OPENSSL_SSLV23_PADDING', found in Reference (4.0.4, ), does not exists.
Failed asserting that false is true.
/builddir/build/BUILD/php-compatinfo-db-f71dbe522b3075505cb5221d3f29b8fb3863dd47/tests/Reference/GenericTest.php:649

[llaville]

@remicollet Can you check/test the fixe on new branch openssl_v3 and validate it please ?

[remicollet]

Still same error
https://kojipkgs.fedoraproject.org//work/tasks/2827/76352827/build.log

[llaville]

After reading the build.log I noticed that you run test on PHP 8.0
But in php/php-src@a0972de#diff-c85372ee14ed2a3e599bc555e3d245e4cd654e4a57f250ba927701dd8b61d102 its tagged at least for PHP 8.1.0beta3

I don't understand. If you can explains my misunderstood, I'd like a lot !

[remicollet]

I don't understand. If you can explains my misunderstood, I'd like a lot !

As Fedora Have OpenSSL 3.0n the needed stuff have been backported from 8.1 to 8.0

[llaville]

I'm sorry, but I follow PHP original source code changes.
As It's specific to Fedora, I suggest you to add a patch by changing value of ext-min and php-min https://github.com/llaville/php-compatinfo-db/blob/c4eeca6b55b916868e45f4efbfcf30b4e8f095c8/data/reference/extension/openssl/81/constants.json

[remicollet]

BTW, the constraint is bad.

-                "constraint": ">=3.0.0"
+                "constraint": "<3.0.0"

[remicollet]

See pr #89

[llaville]

if support is to add optional constant for OpenSSL 3.0, then the constraint is truly >=3.0.0, or I don't really understand reason of your PR 7002 on php-src

[remicollet]

This is NOT a new constant
The constant exists since PHP 4.0.4, and is really optional, ie removed when PHP is build with OpenSSL 3.0.0

"SSLV23" is terribly old and insecure...

[remicollet]

See https://github.com/llaville/php-compatinfo-db/blob/master/data/reference/extension/openssl/40/constants.json#L38

[remicollet]

Perhaps simpler / better, to add the constraint in data/reference/extension/openssl/40/constants.json

[llaville]

The constant exists since PHP 4.0.4, and is really optional, ie removed when PHP is build with OpenSSL 3.0.0

This explain is more usefull for me. I understand now, and I agree constraint is <3.0.0. I will fix it on base **openssl/40/constants.json". You can close your PR 89

[llaville]

I'll merge it on master if it's statisfy your tests !

[remicollet]

Yes new patch is OK.