Merged
Conversation
dineshyv
requested review from
ashwinb,
dltn,
hardikjshah,
raghotham,
sixianyi0721,
vladimirivic and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
reviewed
Jan 14, 2025
ashwinb
approved these changes
Jan 14, 2025
raghotham
reviewed
Jan 15, 2025
raghotham
reviewed
Jan 15, 2025
dineshyv
force-pushed
the
rest-api-updates
branch
4 times, most recently
from
312cd2d to
6148e64
Compare
dineshyv
force-pushed
the
rest-api-updates
branch
from
6148e64 to
b438dad
Compare
dineshyv
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Jan 15, 2025
# What does this PR do? This PR changes our API to follow more idiomatic REST API approaches of having paths being resources and methods indicating the action being performed. Server side changes: llamastack/llama-stack#765 ## Test Plan LLAMA_STACK_BASE_URL=http://localhost:5000/ pytest -v tests/client-sdk/agents/test_agents.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes our API to follow more idiomatic REST API approaches of having paths being resources and methods indicating the action being performed.
Changes made to generator:
Test Plan
LLAMA_STACK_BASE_URL=http://localhost:5000 pytest -v tests/client-sdk/agents/test_agents.py