Conversation
c3ba471 to
7d6e4a6
Compare
e76b086 to
0634303
Compare
0634303 to
d4935ca
Compare
raghotham
reviewed
Dec 17, 2024
raghotham
reviewed
Dec 17, 2024
yanxi0830
approved these changes
Dec 17, 2024
ashwinb
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Dec 17, 2024
See llamastack/llama-stack#635 for the corresponding PR
ashwinb
added a commit
to llamastack/llama-stack-apps
that referenced
this pull request
Dec 18, 2024
See llamastack/llama-stack#635 in llama-stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a long-pending change and particularly important to get done now.
Specifically:
PIL.Imageis infesting all our APIs viaImageMedia -> InterleavedTextMediaand that cannot be right at all. Anything in the API surface must be "naturally serializable". We need a standard{ type: "image", image_url: "<...>" }which is more extensibleUserMessage,SystemMessage, etc. are moved completely to llama-stack from the llama-models repository.See meta-llama/llama-models#244 for the corresponding PR in llama-models.
Test Plan
Updated the client sdk (see PR ...), installed the SDK in the same environment and then ran the SDK tests: