fix: Deprecate items when create conversation #4765
Merged
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyliu513
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
gyliu513
changed the title
mattf
requested changes
Jan 29, 2026
Collaborator
mattf
left a comment
mattf
left a comment
There was a problem hiding this comment.
the items should not be returned when retrieving the conversation
Collaborator
Contributor
Author
|
thanks @franciscojavierarceo and @mattf , seeme we can just remove items from coversation, but end user can query item via GET /v1/conversations/{conversation_id} {
"id": "conv_123",
"object": "conversation",
"created_at": 1741900000,
"metadata": {"topic": "demo"}
}Create conversation {
"id": "conv_123",
"object": "conversation",
"created_at": 1741900000,
"metadata": {"topic": "demo"}
} |
gyliu513
force-pushed
the
item
branch
2 times, most recently
from
5b49fe2 to
afc55f6
Compare
gyliu513
changed the title
mattf
requested changes
Jan 30, 2026
Collaborator
mattf
left a comment
mattf
left a comment
There was a problem hiding this comment.
please add a test to verify that items is not returned on creation or retrieval
Contributor
Author
|
@mattf Done, thanks |
mattf
requested changes
Jan 30, 2026
| conversation = await service.create_conversation(CreateConversationRequest(metadata={"test": "value"})) | ||
|
|
||
| # Verify items is None or not present in creation response | ||
| assert conversation.items is None, "items should be None when creating a conversation" |
Collaborator
There was a problem hiding this comment.
this tests that items exists and is none, it shouldn't exist
Do not need items when create and retrive conversation
mattf
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed #4718