Skip to content

Fix client picking embeddings model by default for chat completion #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimirivic merged 1 commit into from
Dec 19, 2024
Merged

Fix client picking embeddings model by default for chat completion #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/llama_stack_client/lib/cli/inference/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import click
from rich.console import Console

from ..common.utils import handle_client_errors
from ...inference.event_logger import EventLogger
from ..common.utils import handle_client_errors


@click.group()
Expand All @@ -31,7 +31,7 @@ def chat_completion(ctx, message: str, stream: bool, model_id: Optional[str]):
console = Console()

if not model_id:
available_models = [model.identifier for model in client.models.list()]
available_models = [model.identifier for model in client.models.list() if model.model_type == "llm"]
Copy link
Member

@raghotham raghotham Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we have enums for these model types? can we use them instead of string literals?

model_id = available_models[0]

response = client.inference.chat_completion(
Expand Down
Loading