Skip to content

feature/improved image processing #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2023
Merged

feature/improved image processing #737

merged 5 commits into from
Dec 11, 2023

Conversation

@itinerare
Copy link
Member

@itinerare itinerare commented Dec 7, 2023

Improves/makes explicit the WebP support already present, as well as adding several additional image processing and storage improvements and options:

  • Add config setting for which dimension (shorter/longer) to target when resizing masterlist images
  • Add config settings for masterlist fullsize and gallery submission image format
    • Store masterlist fullsize extension separately
    • Add a command to backfill extension for existing fullsizes
  • Add config setting to cap gallery submission image dimensions
  • Add WebP to supported mimes for character images, gallery submission images
  • Use Imagick for processing large (2k+ px in any dimension) images. This helps address GD's difficulty with these (which can lead to unnecessary memory usage spikes and failing to process them), but does require installing imagick if not already present! It's usually available as both its own package (imagemagick) and associated php extension (php8.1-imagick, for instance).
  • Fix background color being applied to WebP images (as they also support transparency).

Requires installing imagemagick/php extension, php artisan migrate, php artisan app:fill-character-fullsize-extensions if there are already fullsize images stored.

itinerare and others added 4 commits December 7, 2023 12:27
@itinerare
feat(characters): add additional image processing options
8529795 
- make masterlist dimension target configurable
- make masterlist fullsize format configurable/stored separately
- fix background application so that webp is excluded
- use imagick for large (2k px+ images)
- add webp to allowed upload formats
- add command to backfill fullsize image extension
@itinerare
refactor(characters): remove unnecessary image processing variables
46b5232
@itinerare
feat(galleries): add additional image processing options
a736629 
- add webp to allowed upload formats
- use imagick for large (2k px+ images)
- add configurable/optional size cap
@itinerare @github-actions
refactor: fix PHP styling
57d2511
@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Dec 7, 2023
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Dec 10, 2023
@itinerare
Copy link
Member Author

itinerare commented Dec 10, 2023 •
edited
Loading

Waiting for #735 to be merged (to be safe).

ScuffedNewt

This comment was marked as resolved.

Sign in to view

@ScuffedNewt
Copy link
Contributor

ScuffedNewt commented Dec 11, 2023

wrong pr lol

@itinerare
Merge branch 'develop'
9aa31db 
Conflicts:
	resources/views/galleries/create_edit_submission.blade.php
@itinerare itinerare merged commit f82a7f2 into lk-arpg:develop Dec 11, 2023
@itinerare itinerare deleted the feature/improved-image-processing branch December 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ScuffedNewt ScuffedNewt ScuffedNewt approved these changes

@SpeedyD SpeedyD SpeedyD approved these changes

@preimpression preimpression preimpression approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request reviewed Pull requests that have received community review and are pending merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@itinerare @ScuffedNewt @SpeedyD @preimpression