fix(meta tags): no more extra spaces #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpeedyD
approved these changes
Aug 19, 2025
Contributor
SpeedyD
left a comment
SpeedyD
left a comment
There was a problem hiding this comment.
This PR let me to research 'hasSection' and 'getSection'.
...It seems I was unaware of an interesting feature, that potentially opens new opportunities for development.
I highly approve of this PR.
Member
|
Yeah, there are a few such tools that Laravel provides and they're great. Anyhow, thanks for taking the time to do this! |
itinerare
approved these changes
Aug 19, 2025
itinerare
added
the
reviewed
MarskyMessier
pushed a commit
to MarskyMessier/lorekeeper
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new blade formatting there has been extra space rendered in meta tag titles when yielded. This trims off the extra space and also only renders the trailing
-after the site's title (as well as the::) if there is an additional title yielded. Below are just preview screenshots displaying the before and after for Discord embeds when linking a user's characters page.Meta descriptions have tags stripped because...I don't think those actually render? (thinking emoji) Previewing the opengraph/facebook/twitter/etc embeds the tags show up along with the text as
<p><strong>so I figured it could just be taken out.