Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on train_neural_network.ipynb #430

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix typo on train_neural_network.ipynb #430

merged 1 commit into from
Nov 9, 2020

Conversation

ainigiri
Copy link
Contributor

@ainigiri ainigiri commented Nov 8, 2020

Description

There is a typo on train_neural_network.ipynb, this PR fix that typo.

Related Issue

Solves Issue #428

Motivation and Context

In cell 5 is defined logits_function, but in cells 6 and 9 is written logits_funciton. This pull request fix the typo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ainigiri ainigiri mentioned this pull request Nov 8, 2020
Closed
@ljvmiranda921 ljvmiranda921 self-assigned this Nov 8, 2020
@ljvmiranda921 ljvmiranda921 self-requested a review November 8, 2020 05:33
@ljvmiranda921 ljvmiranda921 merged commit a6a7ffe into ljvmiranda921:master Nov 9, 2020
@ljvmiranda921
Copy link
Owner

@all-contributors please add @a310883 for docs!

@allcontributors allcontributors bot mentioned this pull request Nov 9, 2020
Merged
@allcontributors
Copy link
Contributor

@ljvmiranda921

I've put up a pull request to add @a310883! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljvmiranda921 ljvmiranda921 ljvmiranda921 approved these changes

Assignees

@ljvmiranda921 ljvmiranda921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ainigiri @ljvmiranda921