Test assertions in search (#27) #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that a bad type for the optimizer parameter to GridSearch() raises a TypeError.
Tests that a bad type for the optimizer parameter or the n_selection_iters parameter
to RandomSearch() raises a TypeError.
Author: jazcap53
Email: andrew.jarcho@gmail.com
I quickly changed a class name just to make it consistent with other tests. I decided to do it on my own to save you the hassle of editing and committing for just a very small fix, and so that we can merge immediately.
ljvmiranda921
approved these changes
Oct 3, 2017
| bad_optimizer = 'LocalBestPSO' # a string instead of a class object | ||
| with self.assertRaises(TypeError): | ||
| g = GridSearch(bad_optimizer, self.n_particles, self.dimensions, |
There was a problem hiding this comment.
I see, I think I understand what you mean earlier. I guess this is the way to go when initializing objects.
| {'c1': 2, 'c2': 6, 'k': 5, 'w': 0.9, 'p': 0}]) | ||
|
|
||
| class Instantiate(Base): |
There was a problem hiding this comment.
Hmmm, just for consistency, please rename this to Instantiation
|
Hey @jazcap53, I believe all the tests you did are fine. There's one tiny fix that I required: changing Either way, all tests are good and this PR will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that a bad type for the
optimizerparameter toGridSearch()raises aTypeError.Tests that a bad type for the
optimizerparameter or then_selection_itersparameterto
RandomSearch()raises aTypeError.Author: jazcap53
Email: andrew.jarcho@gmail.com