Updated sample code to new API #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljvmiranda921
requested changes
Feb 19, 2019
There was a problem hiding this comment.
Hi @ndngo ! Thank you for your contribution!
Some small updates from you before we merge your branch:
- I think it would be better to remove the Dependencies section. Since we have
requirements.txt, there's no need for that anymore - The way we represent the output as seen in the README:
>>> 2017-10-03 10:12:33,859 - pyswarms.single.global_best - INFO - Iteration 1/100, cost: 0.131244226714
>>> 2017-10-03 10:12:33,878 - pyswarms.single.global_best - INFO - Iteration 26/100, cost: 1.60297958653e-05
>>> 2017-10-03 10:12:33,893 - pyswarms.single.global_best - INFO - Iteration 51/100, cost: 1.60297958653e-05
>>> 2017-10-03 10:12:33,906 - pyswarms.single.global_best - INFO - Iteration 76/100, cost: 2.12638727702e-06
>>> 2017-10-03 10:12:33,921 - pyswarms.single.global_best - INFO - ================================
Optimization finished!
Final cost: 0.0000
Best value: [-0.0003521098028145481, -0.00045459382339127453]
Is now outdated. Currently we have a progress bar showing up. I'm wondering how we can show that. Maybe a GIF using ASCIInema might help?
|
@ljvmiranda921 I've removed the dependencies section and added a gif showing the progress bar. |
ljvmiranda921
approved these changes
Feb 22, 2019
Merged
|
Merged! Thank you for your contribution @ndngo ! |
|
@all-contributors please add @ndngo for documentation |
|
I've put up a pull request to add @ndngo! 🎉 |
|
Woops another one, @all-contributors please add @ndngo for documentation |
|
I've put up a pull request to add @ndngo! 🎉 |
|
Does pyswam do multiobjective? Would love to see a user-defined multiobective problem, say 2 and then 3 variables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated sample code in the README to work with the new API
Related Issue
#287
Motivation and Context
The API changed so the code samples in the README needed to be updated to conform to the new API.
How Has This Been Tested?
The code samples were tested by running the code and ensuring that the results are similar to the expected results before the API change. The testing environment was Python 3 on Windows Subsystem for Linux. Each code sample was executed and the output was compared to expected output shown in the README.
Screenshots (if appropriate):
Swarm visualization
Types of changes
Checklist: