Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: Removed '_func' from single obj function names #222

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Re: Removed '_func' from single obj function names #222

merged 1 commit into from
Aug 14, 2018

Conversation

jarcelao
Copy link
Contributor

Description

Same as before, but this time checked out from development branch 😄

Related Issue

Issue #219

Motivation and Context

Merging changes proved to be troublesome.

How Has This Been Tested?

Same changes has been made, tests should work.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ljvmiranda921 ljvmiranda921 self-requested a review August 14, 2018 13:04
ljvmiranda921
ljvmiranda921 approved these changes Aug 14, 2018
View reviewed changes
Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super thanks!

@ljvmiranda921 ljvmiranda921 merged commit 2472ed2 into ljvmiranda921:development Aug 14, 2018
@ljvmiranda921
Copy link
Owner

Thank you @nik1082 ! Hope to see you again!

@jarcelao
Copy link
Contributor Author

Looking forward to it!

@ljvmiranda921 ljvmiranda921 mentioned this pull request Aug 22, 2018
Closed
9 tasks
@jarcelao jarcelao deleted the remove-suffix-from-single-obj-funcs branch October 9, 2018 03:49
@ljvmiranda921 ljvmiranda921 mentioned this pull request Jan 29, 2019
Merged
ljvmiranda921 pushed a commit that referenced this pull request Jan 29, 2019
@jarcelao @ljvmiranda921
Remove _func in single_obj function names (#222)
251a9e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljvmiranda921 ljvmiranda921 ljvmiranda921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarcelao @ljvmiranda921