[update] stringify with comma:true to decode comma for an array as a reserved char per RFC3986 #338
Conversation
|
When the format is "RFC3986", this seems correct. However (see https://github.com/ljharb/qs#rfc-3986-and-rfc-1738-space-encoding) when the format is RFC1738, for example, i would not expect it to be encoded. |
|
will try to do it for RFC3986 only |
ljharb
force-pushed
the
stringify-comma
branch
from
4c4f45b to
8da95de
Compare
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I've rebased this and tweaked some things, but an easy solution hasn't yet presented itself.
| } else { | ||
| if (encoder) { | ||
| var commaKey = encodeValuesOnly ? prefix : encoder(prefix, defaults.encoder, charset, 'key'); | ||
| var commaValue = obj.map(function (item) { |
There was a problem hiding this comment.
we can't add a dependency on .map here.
There was a problem hiding this comment.
@petersolopov Pre-ES5 browsers won't have it. The PR can be rebased and use utils.maybeMap instead.
… for an array as a reserved char
ljharb
force-pushed
the
stringify-comma
branch
from
8da95de to
9be0025
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 99.85% 99.77% -0.08%
==========================================
Files 8 8
Lines 1336 1349 +13
Branches 164 168 +4
==========================================
+ Hits 1334 1346 +12
- Misses 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Om4ar are you no longer interested in completing this PR? Please leave it open even so, so that someone else can complete it. |
3 participants
pr to correctly stringify a array with formatArray as a comma
keeping the comma character decoded to separate items for this character a reserved one per RFC3986
fixes: #337