Skip to content

Commit

Permalink
Merge pull request itsnubix#31 from mrpatiwi/master
Browse files Browse the repository at this point in the history
Change react-native-video to a peer-dependency
  • Loading branch information
Kyle Milloy authored Jul 19, 2017
2 parents c4b323a + c22855c commit b7a0f65
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ By default the `<VideoPlayer>` accepts a navigator property from React's built-i
By default, tapping the screen anywhere will show the player controls. After 10s the controls disappear. Double tapping will toggle fullscreen.

## Installation
Run `npm install --save react-native-video-controls`
Run `npm install --save react-native-video react-native-video-controls`

Then run `react-native link react-native-video`

If you're using RN < 39 run `npm install --save react-native-video-controls@1.0.1`
If you're using RN < 39 run `npm install --save react-native-video-controls@1.0.1`. Note this version includes `react-native-video` as a normal dependency instead of a peer-dependency.

## Usage
The `<VideoPlayer>` component follows the API of the `<Video>` component at [react-native-video](https://github.com/react-native-community/react-native-video). It also takes a number of additional props which are outlined in the [API](#api) section.
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
"url": "git@github.com:itsnubix/react-native-video-controls.git"
},
"dependencies": {
"lodash": "^4.16.4",
"react-native-video": "^1.0.0"
"lodash": "^4.16.4"
},
"peerDependencies": {
"react-native": "^0.42.0"
"react-native": "^0.42.0",
"react-native-video": "^1.0.0"
}
}
17 changes: 17 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1


keymirror@0.1.1:
version "0.1.1"
resolved "https://registry.yarnpkg.com/keymirror/-/keymirror-0.1.1.tgz#918889ea13f8d0a42e7c557250eee713adc95c35"

lodash@^4.16.4:
version "4.17.4"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.4.tgz#78203a4d1c328ae1d86dca6460e369b57f4055ae"

react-native-video@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/react-native-video/-/react-native-video-1.0.0.tgz#ba92b9e1a114c2c1f3a6144b0639ca3f69a0cc74"
dependencies:
keymirror "0.1.1"

0 comments on commit b7a0f65

Please sign in to comment.