Add input: attribute prefix for targeting the input element#2438
Open
joshhanley wants to merge 1 commit intomainfrom
Open
Add input: attribute prefix for targeting the input element#2438joshhanley wants to merge 1 commit intomainfrom
input: attribute prefix for targeting the input element#2438joshhanley wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When using
flux:input, classes and attributes need to be targeted to the inner<input>element rather than the wrapper<div>. Previously, this was only possible using theclass:inputsyntax, which is inconsistent with thenested:attributeconvention used by other Flux components (e.g.,field:class,label:class,container:class).The Problem
The input component only supported the legacy
class:inputsyntax for targeting classes to the<input>element. Other components use thenested:attributeprefix convention (e.g.,field:class,label:class,container:class), but the input component didn't supportinput:classor otherinput:*attributes.The Solution
Added support for the
input:attribute prefix using the sameFlux::attributesAfter()pattern used throughout the codebase. Anyinput:*attributes are extracted and merged onto the<input>element. The existingclass:inputsyntax continues to work for backwards compatibility.