Add Blade fallback for delegate components#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
A user has Blaze installed and uses a custom Flux icon or variant:
Where "custom" is a Blade view in
resources/views/flux/icon/custom.blade.phpwithout a@blazedirective.The problem
The icon component uses
flux::delegate-componentand Blaze assumes all delegate targets are optimized.But the custom icon template doesn't have
@blaze, therefore it's not compiled into a function.Resulting in an exception:
The solution
Instead of forcing all custom components to be blaze-compiled (livewire/flux#2411), we check at runtime whether the delegate target is a Blaze component. If not, we skip Blaze entirely and fall back to standard Blade rendering.
Custom components without
@blazejust work — no configuration needed, no forced compilation.Replaces livewire/flux#2411.