Support whitespace in component and slot tags#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
Laravel's
ComponentTagCompilerallows whitespace between<and>:The problem
The tokenizer matched tags using exact string comparison (
<x-,</x-), so any whitespace caused the tag to be missed entirely.For closing tags, whitespace after the tag was also broken — if the tokenizer didn't find
>immediately after tag name, it would consume the whitespace, the>, any text after it, and everything up until the next tag:The solution
Changed
matchesAtfrom exact string comparison to regex matching, so the tag matchers can use<\s*and<\/\s*— matching Laravel'sComponentTagCompiler:Moved the
>check outside the name-matching block so whitespace after the tag name is skipped.Added dedicated
TokenizerTestcovering tags, slots, whitespace handling, and attributes with angled brackets.