Fix infinite loop caused by null directive callback return#32
Merged
calebporzio merged 1 commit intomainfrom Feb 17, 2026
Merged
Fix infinite loop caused by null directive callback return#32calebporzio merged 1 commit intomainfrom
calebporzio merged 1 commit intomainfrom
Conversation
…ack return The callbacks in Directives::get() and Directives::has() had no return statement, implicitly returning null. This null propagated through BladeCompiler::compileStatements() → replaceFirstStatement(), where strlen(null) evaluated to 0, preventing the offset from advancing and causing an infinite loop during view compilation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Directives::get()andDirectives::has()had no return statement, implicitly returningnullnullpropagated throughBladeCompiler::compileStatements()→replaceFirstStatement(), wherestrlen(null)evaluated to0, preventing the offset from advancing — causing an infinite loop during view compilationreturn '';to both callbacksTest plan
php artisan view:clearwithout fix🤖 Generated with Claude Code