Interface normalizer #200
Merged
Interface normalizer #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added private API for normalizing parts of the interface This is helpful for values that are strings but are better suited for version matching in another type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to pattern match on os and app versions. These values come in as strings, but we should permit the parsing of the string into values that can be better pattern matched on ranges:
The above example presumes the given client has a
os_versionpattern of<major>.<minor>.<patch>Support for the necessary normalization functions must be implemented in the client plugin. Otherwise the interface normalizer ignores.