Skip to content

chore: remove fishtank-specific deployment logic #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

junhyr
Copy link
Collaborator

@junhyr junhyr commented Jun 9, 2025

PR Type

Other


Description

  • Remove fishtank entrypoint script

  • Delete fishtank Dockerfile

  • Remove fishtank Fly config fly.toml

  • Remove GitHub workflow deploy.fishtank.yml


Changes walkthrough 📝

Relevant files
Miscellaneous
entrypoint.sh
Remove fishtank entrypoint script                                               

apps/fishtank/entrypoint.sh

  • Deleted entire entrypoint script
  • Removed ffmpeg streaming loop logic
  • Removed STREAM_URL and RTMP_TARGET env vars
  • +0/-9     
    Configuration changes
    deploy.fishtank.yml
    Remove fishtank deploy workflow                                                   

    .github/workflows/deploy.fishtank.yml

  • Deleted GitHub Actions workflow
  • Removed fishtank deployment on main branch
  • +0/-28   
    Dockerfile
    Remove fishtank Dockerfile                                                             

    apps/fishtank/Dockerfile

  • Removed Dockerfile for fishtank service
  • Deleted base image and ffmpeg installation
  • +0/-8     
    fly.toml
    Remove fishtank Fly config                                                             

    apps/fishtank/fly.toml

  • Deleted Fly deployment configuration
  • Removed app, build, and vm settings
  • +0/-10   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link

    vercel bot commented Jun 9, 2025

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    pipelines-app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 8:08am

    @junhyr junhyr merged commit 170df10 into main Jun 9, 2025
    4 of 6 checks passed
    @junhyr junhyr deleted the jun/fishtank branch June 9, 2025 08:08
    Copy link

    github-actions bot commented Jun 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Workflow cleanup
    Ensure removal of the fishtank workflow does not break any CI/CD pipelines or leave dangling references in other workflows or triggers.

    Orphaned references
    Verify there are no remaining references to fishtank entrypoint, Dockerfile, or fly.toml in documentation, scripts, or other configuration files.

    Copy link

    github-actions bot commented Jun 9, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant