feat: update rtmp target for the fishtank stream

[junhyr]

PR Type

Enhancement

---

Description

• Update RTMP_TARGET to new endpoint

• Add -an flag to disable audio

---

Changes walkthrough 📝

	Relevant files
Configuration changes	entrypoint.sh Update RTMP target and disable audio                                          apps/fishtank/entrypoint.sh Updated RTMP_TARGET URL to new RTMP endpoint Added -an flag to ffmpeg invocation +2/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pipelines-app	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 4, 2025 2:39am

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns Sensitive information exposure: The new RTMP_TARGET contains a streaming key embedded in code. This can lead to unauthorized access; use environment variables or a secret manager instead.

⚡ Recommended focus areas for review Hardcoded endpoint The RTMP_TARGET is hardcoded with a token-like URL; consider sourcing it from an environment variable or a secure configuration to avoid exposing credentials. RTMP_TARGET="rtmp://ai.livepeer.monster/stk_m7QQNZPjUp5wP3NV" Missing error handling The ffmpeg command lacks error logging or retry backoff; failures will silently sleep and retry without visibility. Consider capturing exit codes and logging errors. ffmpeg -rw_timeout 10000000 -timeout 10000000 -an -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET"

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Check ffmpeg exit status Add exit status checking around the ffmpeg command so the loop can break on successful completion or log errors with retry logic. This prevents endless rapid restarts after unexpected failures. apps/fishtank/entrypoint.sh [6-9] while true; do - ffmpeg -rw_timeout 10000000 -timeout 10000000 -an -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET" - sleep 5 + if ffmpeg -rw_timeout 10000000 -timeout 10000000 -an -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET"; then + echo "Stream ended successfully" + break + else + echo "ffmpeg exited with code $?; retrying in 5 seconds" + sleep 5 + fi done Suggestion importance[1-10]: 7 __ Why: The suggestion adds exit status handling to the ffmpeg loop, improving stability and logging.	Medium
General	Retain audio in output Remove the -an flag if audio needs to be preserved, or document its intentional use to avoid accidentally dropping audio in the output stream. apps/fishtank/entrypoint.sh [7] -ffmpeg -rw_timeout 10000000 -timeout 10000000 -an -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET" +ffmpeg -rw_timeout 10000000 -timeout 10000000 -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET" Suggestion importance[1-10]: 5 __ Why: Removing -an preserves audio, which may be important for use cases, though it depends on requirements.	Low
	Consolidate timeout flags Consolidate timeout settings by removing the redundant -timeout flag if it's not supported by the RTMP protocol, or replace it with a protocol-specific option. apps/fishtank/entrypoint.sh [7] -ffmpeg -rw_timeout 10000000 -timeout 10000000 -an -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET" +ffmpeg -rw_timeout 10000000 -re -i "$STREAM_URL" -c copy -f flv "$RTMP_TARGET" Suggestion importance[1-10]: 4 __ Why: Simplifying timeout flags reduces redundancy and clarifies intent without affecting core functionality.	Low