-
Notifications
You must be signed in to change notification settings - Fork 6
box: Add local box run #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Reviewer Guide 🔍(Review updated until commit cd91944)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to cd91944
Previous suggestionsSuggestions up to commit def3bd7
|
<> | ||
<div className="relative w-full h-full"> | ||
<LivepeerPlayer /> | ||
</div> | ||
{!isPlaying && <Overlay />} | ||
</> | ||
) : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this, because I think we don't need it. In staging/prod, we never have a situation when the stream is without output_playback_id
. And for the local run, it should not be required.
Persistent review updated to latest commit cd91944 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine but probably best to have @junhyr check 🙏
PR Type
Enhancement
Description
Provide optional local dev configs and defaults
Ensure user clips fallback to empty array
Always render video player without playback ID
Make Kafka config optional in server env
Changes walkthrough 📝
BentoGridOverlay.tsx
Default empty array for user clips
apps/app/components/welcome/featured/BentoGridOverlay.tsx
data.clips
myClips
state always gets an arrayMainContent.tsx
Always render video player
apps/app/components/welcome/featured/MainContent.tsx
stream.output_playback_id
LivepeerPlayer
componentserverEnv.ts
Optional Kafka configuration
apps/app/lib/serverEnv.ts
kafka
config optional in Zod schema.env.example
Enhanced local dev .env defaults
apps/app/.env.example
NEXT_PUBLIC_USE_PRIVY_MOCK
flag