This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
add last reward round to an orchestrator's campaign view #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit wraps the `fetchMore` call in a try catch to avoid the runtime error thrown by apollo when navigating from the history view to the campaign view or any other route for that matter. apollographql/apollo-client#4114
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/livepeerorg/explorer-20/1yyfyzpno |
yondonfu
reviewed
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds an O's last reward round to its campaign view and adds an indication whether or not it called reward for the current round. It also fixes a runtime error I noticed caused by Apollo that would occur when navigating from the history view to the campaign view (or any other route for that matter) while in the middle of loading more history results.
Does this pull request close any open issues?
Fixes #538
Screenshots (optional):
