Add logic to write platform specific README in native package scaffolding#27
Merged
Add logic to write platform specific README in native package scaffolding#27
Conversation
1egoman
commented
Feb 6, 2026
Comment on lines
+20
to
+24
| /// The value of the "name" field in the main package's "package.json". Used to add context to | ||
| /// the README.md about the purpose of the package. | ||
| #[arg(long, default_value = None)] | ||
| lib_package_name: Option<String>, | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I made this optional because I think there are situations where the parent package may not be clear at build time / it may not make sense to include it in the readme. Making this required also then breaks the nice <lib source> <triple> required args pattern which makes getting started slower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.