Update inbound.go #369
Open
Update inbound.go #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found issue when call won't hung-up if did not met Dispatch Rules . Caller will ring forever until decide to hung-up
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 65.25% 62.36% -2.90%
==========================================
Files 51 32 -19
Lines 6588 6302 -286
==========================================
- Hits 4299 3930 -369
- Misses 1915 1997 +82
- Partials 374 375 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
best one set to |
|
This is intentional, so that we are not answering SIP spam. Automated scanners would (hopefully) think it's not a SIP server if we do not respond with a proper status code. |
|
I see . That makes sense.
Then maybe a good option would be enable response or disable via config
YAML .
Anyway, thank you for your reply .
Best regards
…On Wed, May 21, 2025 at 3:57 PM Denys Smirnov ***@***.***> wrote:
*dennwc* left a comment (livekit/sip#369)
<#369 (comment)>
This is intentional, so that we are not answering SIP spam. Automated
scanners would (hopefully) think it's not a SIP server if we do not respond
with a proper status code.
—
Reply to this email directly, view it on GitHub
<#369 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWKDVNEQEHWFCT2LM2PKAXT27RZ5NAVCNFSM6AAAAAB5RWIL26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJXHA3TONRWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
YAML option makes sense. Actually we already have it: |
|
Sounds good!
…On Tue, May 27, 2025 at 1:45 AM Denys Smirnov ***@***.***> wrote:
*dennwc* left a comment (livekit/sip#369)
<#369 (comment)>
YAML option makes sense. Actually we already have it: HideInboundPort. So
let's add it to switch this behavior.
—
Reply to this email directly, view it on GitHub
<#369 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWKDVNGTFKOFHJ25JBLMZC33AOKSDAVCNFSM6AAAAAB5RWIL26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJQG4ZDGMBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found issue when call won't hung-up if did not met Dispatch Rules . Caller will ring forever until decide to hung-up