Remove participant check for data packets #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed check for participant existence before processing data packets.
s-hamdananwar
deleted the
hamdan/remove-participant-check-data-channels
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check ends up dropping packets when
send_datais called, and when a data packet is published on a project with livestream mode. The former fails because this line returns Some(ParticipantIdentity("")) and not None, as user.participant_identity.try_into().ok() converts none to string. The latter fails because in livestream mode, participant list is not populated. Other SDKs (for eg. JS) are not doing this check. Removing this check should address both issues.