-
Notifications
You must be signed in to change notification settings - Fork 116
livekit, livekit-ffi: Update to v2 APIs #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
looking into |
|
The async Sid for room is due to the fact that the sid returned in the join response could still be empty edit: this is how we handle it for the js-client today |
|
pushed an async sid() proof of concept, if you could review the general idea while i work out the kinks
|
710e8c0 to
804ae50
Compare
|
Nice, lgtm, have you been able to test the changes? |
|
unfortunately i wasn't able to run any of the sample code in the examples directories, even under the main branch. might have something to do with my linux distro + display server combo, but that's outside the scope of this PR |
|
Can you try an example that doesn't use any display env? Like compiling livekit_ffi and trying it on Python/Node |
confirmed working with |
theomonnom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok nice lgtm!
highly wip, went through the migration notes and the
v1.15.7..v2.0.0commit log for client-sdk-js and made some API changes. doesn't include any non-API-breaking change from client-sdk-js, nor any API additions from versions later than 2.0.0.builds fine, but untested, couldn't get any of the examples to work even on main (perhaps my NixOS/Wayland system is confusing)
DataPacketnow usesreliable: booland notkind: DataPacketKindget_track→get_track_publicationetcparticipants→remote_participantscouldn't find any mentions ofVideoQuality::OFFremovalVideoQuality::OFFhere in the realtime SDKsid()Cargo.tomlversions in affected crates