Sxian/clt 2522/add protocol version to participant info#1400
Sxian/clt 2522/add protocol version to participant info#1400xianshijing-lk wants to merge 3 commits intomainfrom
Conversation
|
protobufs/livekit_models.proto
Outdated
|
|
||
| // NEXT_ID: 20 | ||
| // protocol version of the participant, used for backward compatibility | ||
| optional int32 protocol_version = 20; |
There was a problem hiding this comment.
Maybe this should be uint32?
a538ed9 to
684edbd
Compare
lukasIO
left a comment
There was a problem hiding this comment.
In order to support setting the version at connection time (informing the SFU) it will have to be added also to ClientInfo here
protocol/protobufs/livekit_models.proto
Lines 528 to 529 in 2bb10a5
I'm not sure if protocol_version is the right name given we have protocol and agent_protocol already as existing fields. Maybe something like client_protocol instead?
The clients will use the protocol_version to decide:
1, if we should use the streamed response for RPC messages
2, if RPC can use compression for large messages
And it will help being backward compatible with older versions