Skip to content

Sxian/clt 2522/add protocol version to participant info#1400

Open
xianshijing-lk wants to merge 3 commits intomainfrom
sxian/CLT-2522/add_protocol_version_to_ParticipantInfo
Open

Sxian/clt 2522/add protocol version to participant info#1400
xianshijing-lk wants to merge 3 commits intomainfrom
sxian/CLT-2522/add_protocol_version_to_ParticipantInfo

Conversation

@xianshijing-lk
Copy link

The clients will use the protocol_version to decide:
1, if we should use the streamed response for RPC messages
2, if RPC can use compression for large messages

And it will help being backward compatible with older versions

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: 83abd89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.


// NEXT_ID: 20
// protocol version of the participant, used for backward compatibility
optional int32 protocol_version = 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be uint32?

@xianshijing-lk xianshijing-lk force-pushed the sxian/CLT-2522/add_protocol_version_to_ParticipantInfo branch from a538ed9 to 684edbd Compare February 4, 2026 21:22
@lukasIO lukasIO requested a review from boks1971 February 4, 2026 21:26
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to support setting the version at connection time (informing the SFU) it will have to be added also to ClientInfo here

int32 protocol = 3;
string os = 4;

I'm not sure if protocol_version is the right name given we have protocol and agent_protocol already as existing fields. Maybe something like client_protocol instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants